ci(sca): add npm ci before Trivy scan for full dependency scanning#22
Merged
ci(sca): add npm ci before Trivy scan for full dependency scanning#22
Conversation
Install actual node_modules so Trivy can scan the full dependency tree rather than just package-lock.json metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm cistep before Trivy scan so it can inspect actualnode_modulesrather than justpackage-lock.jsonmetadataWhy
Without
npm ci, Trivy only readspackage-lock.jsonmetadata which has limited CVE coverage. Installing fullnode_modulesallows Trivy to scan the complete dependency tree.